[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Submitting patches from magit

From: Jonas Bernoulli
Subject: Re: Submitting patches from magit
Date: Thu, 19 Dec 2019 23:24:30 +0100
User-agent: mu4e 1.1.0; emacs 27.0.50

address@hidden writes:

>> Assuming this is only useful with Magit installed, would it make more sense
>> for it to be contributed to Magit?
> Maybe.  The package monkeys a magit menu to seamlessly insert itself, so
> embedding within magit would actually *reduce* the lines of code.

Instead of the magit-patch-changelog-initialize hack use:

  (transient-append-suffix 'magit-patch-create "c"
    '("e" "Create patches for Emacs" magit-patch-changelog-create))

Also don't fiddle with after-init-hook.  Just put this at the top-level.

> But I suspect Mr. Bernoulli would not want such an emacs-devel-specific task
> to be integrated into a fully general git porcelain.

Yes, I think this should remain a separate package.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]