[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Hollow cursor under images

From: Evgeny Zajcev
Subject: Re: Hollow cursor under images
Date: Mon, 3 Feb 2020 14:24:01 +0300

вт, 28 янв. 2020 г. в 21:22, Eli Zaretskii <address@hidden>:
> From: Evgeny Zajcev <address@hidden>
> Date: Tue, 28 Jan 2020 14:55:39 +0300
> Cc: Alan Third <address@hidden>, emacs-devel <address@hidden>
> I tried to fulfill all the review comments in this updated patch

Thanks.  A few minor comments below.

> * buffer.c (cursor-type): Add commentary about (box . WIDTH)
>   cursor-type

End this sentence with a period.

> * xdisp.c (get_specified_cursor_type): Check for `cursor-type' in form
>   (box . WIDTH)


> * xdisp.c (get_window_cursor_type): Check masked image size for
>   (box . WIDTH) cursor-type.

Changes in several functions in the same file should mention the file
name just once.  Like this:

  * xdisp.c (get_specified_cursor_type): Check for `cursor-type' in form
  '(box . WIDTH)'.
  ((get_window_cursor_type): Check masked image size for(box . WIDTH)

> * doc/emacs/display.texi, doc/emacs/display.texi: Add description
>   for (box . WIDTH) `cursor-type'
> * etc/NEWS: Add note about (box . WIDTH) `cursor-type'

Period missing at end of each sentence.

> +@code{(box . @var{width})} (box cursor becoming a hollow box under
> +masked images larger than @var{width} in either dimension),

I think it's better to use "size", not 'width" here, because "width"
is closely associated with only one dimension, and you mean both.  Or
maybe even "min-size", for better mnemonic value.

Yes! I like "size" name too
> +** Support for `(box . WIDTH)' cursor-type.  By default, `box' cursor
> +always has a filled box shape.  Unless you specify cursor-type to be
> +`(box . WIDTH)'.  In such case, cursor becomes a hollow box if the
> +point is under masked image larger than `WIDTH' in any dimension.

The first sentence of a NEWS entry should be alone on the header
line.  That's because NEWS is visited in Outline mode, where users can
hide the text of the entry, leaving just the headings.  So leave only
the first sentence on the heading line, and move all the rest to the
body starting from the next line.

Also, we prefer quoting 'like this' in NEWS (and in log messages,

Here is the updated version, tried to fix all the formatting issues.


Attachment: 0001-Support-for-box-.-SIZE-cursor-type.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]