[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Small frameset bug

From: Robert Pluim
Subject: Re: Small frameset bug
Date: Mon, 03 Feb 2020 16:13:00 +0100

>>>>> On Mon, 3 Feb 2020 09:55:48 -0500, JD Smith <address@hidden> said:

    JD> In `frameset--minibufferless-last-p`, the destructuring statements:

    JD> (pcase-let ((`(,hasmini1 ,id-def1) (assq 'frameset--mini (car state1)))
    JD>               (`(,hasmini2 ,id-def2) (assq 'frameset--mini (car 

    JD> do not function as intended.  Since the `assq` always produces 
‘frameset—mini` as its car, hasmini1/2 are always set to this symbol. The 
subsequent `cond` still works as intended to sort minibufferless frames last:

    JD>     (cond ((eq id-def1 t) t)
    JD>           ((eq id-def2 t) nil)
    JD>           ((not (eq hasmini1 hasmini2)) (eq hasmini1 t))
    JD>           ((eq hasmini1 nil) (or id-def1 id-def2))
    JD>           (t t))))

    JD> but the 3rd and 4th conditions are never met.  This may cause confusion 
for anyone trying to use the ‘frameset—mini frame parameter.

I guess youʼre looking in emacs-26? In emacs-27 'cdr' is applied to
the 'assq' result.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]