[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 0/3] Improved rxvt support

From: Stefan Monnier
Subject: Re: [PATCH v2 0/3] Improved rxvt support
Date: Sun, 08 Mar 2020 14:13:51 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Thanks Daniel, I just pushed those 3 (squashed and with minor tweaks to
the commit messages).

Sorry it took a bit longer than planned,


> From: Daniel Gröber <address@hidden>
> Hi Stefan,
> On Tue, Mar 03, 2020 at 03:22:24PM -0500, Stefan Monnier wrote:
>> I don't have rxvt to test, but the patch looks good.  What I wonder if
>> whether it would make sense to use even more of `terminal-init-xterm` in
>> rxvt.el.
>> E.g. focus-tracking, frame-title?
> urxvt doesn't have native focus tracking support, there are perl extensions
> to do it but I don't see a good way to feature detect it. Either way the
> control sequence would be different since perl extension cannot catch
> arbitary seqs but just one specific CSI sequence.
> I think it's best to leave that to users if they want support for
> that. I added a terminal-init-rxvt-hook like in xtermel for that.
>> I also see that terminal-init-xterm tries to detect when it's been
>> accidentally called in rxvt, and in that case it still keeps most of
>> terminal-init-xterm intact.  Apparently, this is right for
>> bracketed-paste, but what about the rest?
> As for {get,set}-selection there doesn't seem to be an equivalent upstream
> and I also can't find any extension for that.
> xterm-set-window-title looks to be compatible with rxvt though, I
> copied that over.
> --Daniel
> Daniel Gröber (3):
>   term/rxvt: Enable bracketed paste mode
>   term/rxvt: Add window title support
>   term/rxvt: Add terminal-init hook
>  lisp/term/rxvt.el | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)
> --
> 2.20.1

reply via email to

[Prev in Thread] Current Thread [Next in Thread]