emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pcase.el: Add type pattern


From: Stefan Monnier
Subject: Re: [PATCH] pcase.el: Add type pattern
Date: Mon, 16 Mar 2020 08:59:24 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> Thanks, that's a good point.  This new patch improves the docstring and
> the changes to the manual, and it adds a test for a cl-typep list form.
> Please let me know if more improvements should be made.

The code looks good, except for the fact that it only works after
(require 'cl-lib), so if we want to put it into `cl-lib` like that, we
should use a name like `cl-type` rather than `type`.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]