INSIDE_EMACS and Tramp (was: master f28166d: Copy INSIDE_EMACS env variable to subprocesses in Eshell (Bug#25496))

[Michael Albinus]

address@hidden (Noam Postavsky) writes:

> +** Eshell
> +
> +---
> +*** Environment variable INSIDE_EMACS is now copied to subprocesses.
> +Its value equals the result of evaluating '(format "%s,eshell" 
> emacs-version)'.

This reminds me of a problem lying around for a while. Tramp, like other
packages, sets the environment variable INSIDE_EMACS. So if you eval

--8<---------------cut here---------------start------------->8---
(let ((default-directory "/ssh::"))
  (shell-command-to-string "echo $INSIDE_EMACS"))
--8<---------------cut here---------------end--------------->8---

you get "28.0.50,tramp:2.5.0-pre". But if you run in an eshell buffer

--8<---------------cut here---------------start------------->8---
~/src/emacs $ cd /ssh::
/ssh:detlef:/home/albinus $ *echo $INSIDE_EMACS
--8<---------------cut here---------------end--------------->8---

you get "28.0.50,eshell". Tramp's setting is overwritten.

Shouldn't the specifics be merged, so that we get
"28.0.50,eshell,tramp:2.5.0-pre"?

Same for the other packages setting INSIDE_EMACS, like compile, comint,
term and epg.

Best regards, Michael.