Re: Emacs 27 face :extend attribute not working with pulse.el?

[Adam Porter]

Eli Zaretskii <address@hidden> writes:

>> From: Adam Porter <address@hidden>
>> Date: Thu, 09 Apr 2020 08:18:59 -0500
>> 
>> > I think this issue may be in pulse.el, because evaluating this code has
>> > the same problem:
>> >
>> >   (pulse-momentary-highlight-one-line (point))
>> 
>> After further investigation, I've found that setting ":extend t" on the
>> pulse-highlight-face seems to fix the problem and restore the behavior
>> seen in Emacs 26.3.
>
> Yes, that is the right solution, I think.  But the default should stay
> with the :extend attribute nil, IMO.
>
>> This seems like an obvious, easy fix to restore the previous behavior,
>> but I don't know if it's the "correct" one, because it appears to have
>> the side effect of forcing extension even when
>> pulse-momentary-highlight-one-line is called with a face argument which
>> does not have ":extend t" set.
>
> Does the patch below produce good results?
>
> diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el
> index 16243e1..8649254 100644
> --- a/lisp/cedet/pulse.el
> +++ b/lisp/cedet/pulse.el
> @@ -161,6 +161,9 @@ pulse-reset-face
>                          (face-background face nil t)
>                        (face-background 'pulse-highlight-start-face)
>                        ))
> +  (and face
> +       (set-face-extend 'pulse-highlight-face
> +                        (face-extend-p face nil t)))
>    (put 'pulse-highlight-face :startface (or face
>                                           'pulse-highlight-start-face))
>    (put 'pulse-highlight-face :iteration 0))

Yes, it seems to behave as expected.  Thanks.

> P.S. And *please* in the future report bugs with report-emacs-bug.  It
> is tedious to have to mention the URL of emacs-devel discussion in the
> log message, instead of just mentioning the bug number.

Understood, thanks.