Re: [PATCH] Fix misnamed variable breaking GNUstep Emacs.app build

[Alan Third]

On Fri, Apr 17, 2020 at 04:14:39PM -0700, Ahmed Khanzada wrote:
> After a recent refactor of ns_set_offset in nsterm.m, I noticed that the
> latest version of Emacs was not compiling under GNUstep.
> 
> I believe that this patch should fix the problem, but it could use review
> from someone more familiar with the code. Emacs now compiles fine, and I
> am writing this very email in an Emacs compiled with this patch.

The fix looks good to me. If you want to create a proper patch (as
described in CONTRIBUTE) I’ll happily push it to the repository for
you.

> Additionally, if you need any help maintaining Emacs.app under GNUstep,
> please reach out to me. I am very interested, and I have already signed
> legal documents with the FSF to contribute to Emacs (and soon, GNUstep)

Any help with the NS port would be greatly appreciated. We do keep
compatibility with GNUstep, but most NS port development happens on
macOS, so silly mistakes in GNUstep code, like this one, tend to be
overlooked for a while.

Even raising bug reports for GNUstep would be a plus, since we seem to
have almost no users, and the only people who notice problems are
Emacs devs doing test builds.
-- 
Alan Third