emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Auto-resizing of images in image-mode


From: Juri Linkov
Subject: Re: Auto-resizing of images in image-mode
Date: Wed, 22 Apr 2020 00:28:14 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)

>> Is it important to maintain compatibility between doc-view and image-mode?
>
> I think it's more important to align the keybinding of those two modes
> than it is to preserve existing key bindings.

's' is too good prefix key to give up on so easily.
It has nice mnemonics:

s h             set height
s w             set width
s r             set rotation
s s             set scale

So if preserving old keybindings is not a requirement,
then doc-view slice commands could be rebound to the prefix 'c'
that has good mnemonics too, where 'c' means 'cut', 'clip'.

@Tassilo: Do you agree this would be a change for the better?

diff --git a/lisp/doc-view.el b/lisp/doc-view.el
index 8b3d5527f0..a65e06d4d8 100644
--- a/lisp/doc-view.el
+++ b/lisp/doc-view.el
@@ -421,10 +421,10 @@ doc-view-mode-map
     ;; Killing the buffer (and the process)
     (define-key map (kbd "K")         'doc-view-kill-proc)
     ;; Slicing the image
-    (define-key map (kbd "s s")       'doc-view-set-slice)
-    (define-key map (kbd "s m")       'doc-view-set-slice-using-mouse)
-    (define-key map (kbd "s b")       'doc-view-set-slice-from-bounding-box)
-    (define-key map (kbd "s r")       'doc-view-reset-slice)
+    (define-key map (kbd "c s")       'doc-view-set-slice)
+    (define-key map (kbd "c m")       'doc-view-set-slice-using-mouse)
+    (define-key map (kbd "c b")       'doc-view-set-slice-from-bounding-box)
+    (define-key map (kbd "c r")       'doc-view-reset-slice)
     ;; Searching
     (define-key map (kbd "C-s")       'doc-view-search)
     (define-key map (kbd "<find>")    'doc-view-search)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]