[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] [WIP] Port feature/native-comp to Windows.
From: |
Andrea Corallo |
Subject: |
Re: [PATCH] [WIP] Port feature/native-comp to Windows. |
Date: |
Wed, 13 May 2020 15:17:30 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Nicolas Bértolo <address@hidden> writes:
>> Is there some specific reason for this choice?
>
> The problem is that w32_delayed_load will return a NULL handle if
> Fassq (library_id, Vlibrary_cache)) returns non-nil. The only way to make this
> work is to avoid adding gccjit to Vlibrary_cache if the initialization failed.
> This would be different from what the code for loading other libraries does.
> I don't know if it is worth it to introduce this difference.
>
> Another issue is that this code is called from
> maybe_defer_native_compilation().
> A version that searches for libgccjit all the time would call LoadLibrary()
> and
> perform an expensive search throughout the filesystem everytime `defalias` is
> called.
Uh I see! Yes then I think this solution is okay if the behavior is
acceptable to win users. Otherwise would be necessary a new way for
maybe_defer_native_compilation to check only for the last known state
without triggering a new search.
>>> PS: Shall I open a bug where we can track this?
>> If affect all Emacs I think is the right thing to do.
>
> I referred to opening a bug report for the work related to porting
> feature/native-comp to Windows.
I think is a good idea, Eli will suggest.
Thanks
Andrea
--
address@hidden
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., (continued)
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Stefan Monnier, 2020/05/11
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Fabrice Popineau, 2020/05/11
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Nicolas Bértolo, 2020/05/11
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Eli Zaretskii, 2020/05/12
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Nicolas Bértolo, 2020/05/12
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Andrea Corallo, 2020/05/12
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Andrea Corallo, 2020/05/12
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Nicolas Bértolo, 2020/05/13
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Andrea Corallo, 2020/05/13
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Nicolas Bértolo, 2020/05/13
- Re: [PATCH] [WIP] Port feature/native-comp to Windows.,
Andrea Corallo <=
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Eli Zaretskii, 2020/05/13
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Richard Stallman, 2020/05/12
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Nicolas Bértolo, 2020/05/13
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Eli Zaretskii, 2020/05/13
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Eli Zaretskii, 2020/05/13
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Andrea Corallo, 2020/05/10
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Andrea Corallo, 2020/05/10
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Andrea Corallo, 2020/05/10
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Eli Zaretskii, 2020/05/10
- Re: [PATCH] [WIP] Port feature/native-comp to Windows., Andrea Corallo, 2020/05/10