[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 31395511: "Don’t attempt to modify constant strings"

From: Basil L. Contovounesios
Subject: Re: 31395511: "Don’t attempt to modify constant strings"
Date: Thu, 04 Jun 2020 00:20:51 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Pip Cet <pipcet@gmail.com> writes:

> On Wed, Jun 3, 2020 at 10:42 PM Paul Eggert <eggert@cs.ucla.edu> wrote:
>> On 6/3/20 2:52 PM, João Távora wrote:
>> > Not sure where the problem lies but every button inserted by SLY is now
>> > just plain text.
>> It's because I messed up in that part of the patch. Thanks for reporting the
>> bug. I installed the attached patch into master; please give it a try.
> I don't understand that change at all. All it does is replace a
> six-argument setq by two successive setqs? Surely the symbol value is
> irrelevant for the first, third, etc. argument to setq, so what
> difference does it make?

Indeed the patch seems like a noop and shouldn't fix João's issue, which
is that until now make-text-button modified its argument.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]