[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: RFC: Automatic setup for bug-reference-mode

From: Dmitry Gutov
Subject: Re: RFC: Automatic setup for bug-reference-mode
Date: Sun, 14 Jun 2020 23:51:21 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

On 14.06.2020 23:39, Tassilo Horn wrote:
Actually, "git ls-remote --get-url" doesn't work satisfactory which I
noticed after committing above change on a new local branch.  In that
case, it returned "." so I've changed to this version

(defun vc-git-repository-url (file-or-dir)
   (let ((default-directory (vc-git-root file-or-dir)))
       (vc-git-command (current-buffer) 0 nil "remote" "get-url" "origin")
       (buffer-substring-no-properties (point-min) (1- (point-max))))))

where I explicitly name the remote "origin" (which, I know, doesn't need
to exist but still works in 99% of all cases).

Sounds good!

If the new version can be used in vc-git-dir-extra-headers, could you please make it so?

That aside, I was going to ask whether the new backend method should take a "remote-name" argument, but I don't know how many backends support different remotes. Or what other actual code is going to use this method anyway.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]