[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 9ade7ea: Fix Eldoc problem when loading on Emacs 26.3

From: João Távora
Subject: Re: master 9ade7ea: Fix Eldoc problem when loading on Emacs 26.3
Date: Fri, 10 Jul 2020 22:58:18 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> Maybe come up with a better idea, or maybe, like Stefan suggests, don't
>>> make it an alias at all, just deprecate it and keep using it instead of
>>> eldoc-documentation-strategy when we find it to be bound.
>> That sort of works, but it forces extensions that do want to
>> "Package-Require" eldoc to remember to unbind
>> eldoc-documentation-function if they are loaded on older Emacs versions,
>> which is undesirable.
> Maybe use a rule like:
>     (if (and (buffer-local-p 'eldoc-documentation-function)
>              (not (buffer-local-p 'eldoc-documentation-functions)))
>         <Use `eldoc-documentation-function`>
>       <Use `eldoc-documentation-functions`>

Sounds a bit complicated for me, especially since there's already a
eldoc--supported-p which does similar heuristics.  Wouldn't it break in
some older Emacs version that loads the new Eldoc and has some global
value in eldoc-documentation-functions (say, a spell-checking eldoc

For now, I'd like to go with the alias/reverse-alias technique, which is
the simplest, I think, for this simple problem.  I've tested it and it
works correctly.  Have you seen the patch?  Do you see any blockers
there?  We can move on to some more sophisticated version later.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]