[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Minor simplification in byte-opt.el

From: Stefan Monnier
Subject: Re: Minor simplification in byte-opt.el
Date: Mon, 27 Jul 2020 10:24:49 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

>> Could someone look over the patch below to confirm it's safe?
> Thank you, looks decent to me. Good that you spotted the 1+/1-, I forgot 
> about those.


>> Also, as a result of this, there is only one call to
>> `byte-optimize-form-code-walker` left, in `byte-optimize-form`, so maybe
>> the two functions could be merged, tho it's probably not worth the trouble.
> Maybe -- there seems to be little to gain from integrating them other than
> the elimination of the function call.

Exactly :-(

> By the way, what about this little improvement?

Looks good [ tho IMO we shouldn't support `closure` there.  ]


reply via email to

[Prev in Thread] Current Thread [Next in Thread]