[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHv2] erc: fix erc-reuse-buffers behavior

From: Mingde (Matthew) Zeng
Subject: Re: [PATCHv2] erc: fix erc-reuse-buffers behavior
Date: Fri, 31 Jul 2020 10:03:29 -0400
User-agent: mu4e 1.4.10; emacs 27.0.91

Thanks for the review! Addressed in my new patch.

> Can this and other occurrences of string-match be replaced with 
> string-match-p?
My new patch only fixed the string-match that I introduced.
I did a search and found *many* string-match in the current codebase. I suggest 
investigate them further to see if most of them can be replaced with 
string-match-p in a separate commit.

> FWIW, #' is redundant on (lambda ...) in Elisp.
A new commit could be used to change all #'(lambda ...) to (lambda ...), if 
it's worth the hassle.


Mingde (Matthew) Zeng

reply via email to

[Prev in Thread] Current Thread [Next in Thread]