[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHv3] erc: fix erc-reuse-buffers behavior

From: Mingde (Matthew) Zeng
Subject: Re: [PATCHv3] erc: fix erc-reuse-buffers behavior
Date: Mon, 03 Aug 2020 23:00:32 -0400
User-agent: mu4e 1.4.12; emacs 27.0.91

Amin Bandali <bandali@gnu.org> writes:

> Thanks for the patch, Matthew.
> I just noticed Lars installed 6f94c2405f4c82b63da19de89549aff1fad7e594
> on master, changing erc-generate-new-buffer-name.  Will your patch
> require adjusting to accommodate Lars's changes?

I had a look at Lars' change, that particular commit simply changes target to 
(not target), it is not enough to fix the problem entirely (as outlined in my 
commit message). Also, changing to (not target) technically does avoid this 
specific problem, but imo it logically doesn't make sense. When invoking 
`erc-generate-new-buffer-name`, target is not an optional parameter and should 
never be nil, that line is unnecessary amd therefore removed from my commit.

Yes, I could adjust to accommodate Lars' changes, but I would remove the (not 
target) line, following my original logic, which is the only line Lars changed. 
Unless I am convinced that (not target) line is necessary to exist.

I have another question, since I've never contributed to Emacs directly before, 
can you tell me is there any way to quickly find out whether a bug is tracked 
by GNU bug reports or not?

> Minor nits:
> - Please omit the "Signed-off-by:" from your commit messages to Emacs.
> - Consider dropping the second "* lisp/erc/erc.el" for (erc-cmd-JOIN),
>   since the previous entry (erc-generate-new-buffer-name) was also a
>   change to lisp/erc/erc.el.

Will fix them in a future patch, after the above is resolved.

> Thanks.

Mingde (Matthew) Zeng

reply via email to

[Prev in Thread] Current Thread [Next in Thread]