[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] TTY Support for ECMA-48 strike-through graphic rendition
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH] TTY Support for ECMA-48 strike-through graphic rendition |
Date: |
Wed, 12 Aug 2020 17:23:38 +0300 |
> From: Robert Pluim <rpluim@gmail.com>
> Cc: Mike Hamrick <mikeh@muppetlabs.com>, emacs-devel@gnu.org
> Date: Wed, 12 Aug 2020 11:36:29 +0200
>
> >>>>> On Tue, 11 Aug 2020 22:17:08 +0300, Eli Zaretskii <eliz@gnu.org> said:
>
> Eli> Please use our style of indentation in C source files (basically,
> make
> Eli> sure indent-tabs-mode is non-nil).
>
> That is not reflected in our .dir-locals.el for C files (for elisp it
> sets indent-tabs-mode to nil)
Because it's the default, I believe. Also because we couldn't agree
on a mandatory setting at the time this setting in .dir-locals.el was
discussed.
> I thought it was 'you can use tabs or spaces, but try match the usage
> of existing code when making changes' (which since Iʼm pro-space means
> that when making additions or when the lines Iʼm changing have a mix,
> I use spaces).
That would also indicate that the change in question should have used
mixed TABs and SPACEs.