[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Recursive Fload and eval-after-load forms. (See bug #43116.)

From: Stefan Monnier
Subject: Re: Recursive Fload and eval-after-load forms. (See bug #43116.)
Date: Tue, 01 Sep 2020 19:42:33 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> -        (cond ((symbolp load) (ignore-errors (require load)))
> +        (cond ((being-loaded-p load))   ; For bug #43116
> +              ((symbolp load) (ignore-errors (require load)))

Maybe a simpler test that doesn't require a new ad-hoc primitive is to
test whether that group has already been defined?


diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el
index 466727630f..8f1e5968b5 100644
--- a/lisp/cus-edit.el
+++ b/lisp/cus-edit.el
@@ -4844,7 +4844,8 @@ custom-menu-create
     (if (and (or (not (boundp 'custom-menu-nesting))
                 (>= custom-menu-nesting 0))
-              (custom-load-symbol symbol)
+              (unless (get symbol 'group-documentation)
+                (custom-load-symbol symbol))
               (< (length (get symbol 'custom-group)) widget-menu-max-size)))
        (let ((custom-prefix-list (custom-prefix-add symbol

reply via email to

[Prev in Thread] Current Thread [Next in Thread]