[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: feature/icomplete-vertical

From: jixiuf
Subject: Re: feature/icomplete-vertical
Date: Mon, 14 Sep 2020 14:44:59 +0800

2020年9月12日 下午9:33,Ergus <spacibba@aol.com> 写道:

On Sat, Sep 12, 2020 at 01:10:57PM +0000, Gregory Heytings wrote:

If there was a built-in vertical mode it would be better / more intuitive.

Could you try the branch feature/icomplete-vertical? I need some testers before adding it to master.

Alas no, I have been using the following to have icomplete-vertical for quite some time, it works perfectly well, so I don't see why a more complex implementation would be necessary.

(setq icomplete-prospects-height 6)
(setq icomplete-separator "\n")
(defun icomplete-vertical-minibuffer-setup ()
(setq truncate-lines t)
(setq-local completion-ignore-case t)
(setq-local read-file-name-completion-ignore-case t)
(setq-local read-buffer-completion-ignore-case t)
(setq icomplete-hide-common-prefix nil))
(add-hook 'icomplete-minibuffer-setup-hook #'icomplete-vertical-minibuffer-setup)
(defun icomplete-vertical-reformat-completions (completions)
  (let ((cnp (substring-no-properties completions)))
    (if (string-match "^\\((.*)\\|\\[.+\\]\\)?{\\(\\(?:.\\|\n\\)+\\)}" cnp)
        (format "%s \n%s"
                (or (match-string 1 cnp) "")
                (replace-regexp-in-string "^" (make-string (current-column) ? ) (match-string 2 cnp)))
(defun icomplete-vertical-adjust-minibuffer-height (completions)
(let* ((comp (icomplete-vertical-reformat-completions completions))
       (complen (length (split-string comp "\n"))))
  (if (> complen 1) (enlarge-window (- icomplete-prospects-height (1- (window-height)))))
(advice-add 'icomplete-completions :filter-return #'icomplete-vertical-adjust-minibuffer-height)

1) Internal functionalities try not to use advises.
2) The branch is not actually more complex, it just generates the
formatted vertical output form the beginning.
3) It does more or less the same you are doing but with a simpler

(icomplete-mode t)
(icomplete-format 'vertical)

4) We add arrow bindings to move
5) Add completion matching faces is also coming.

Some feedback about  branch : feature/icomplete-vertical  

I tried this branch with config:

  (icomplete-mode 1)
  (setq icomplete-format 'vertical)

And found this bug still exists:

Some related links about how to work around this bug:

Hope the problem of   disappearing prompt and entered text problem can be fixed in your branch. 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]