[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Uniquify change [PATCH]

From: Ergus
Subject: Re: Uniquify change [PATCH]
Date: Tue, 15 Sep 2020 13:34:55 +0200

On Sun, Sep 13, 2020 at 03:02:44PM -0400, Stefan Monnier wrote:
I want to add this patch to master. Could you give it a look and suggest
where in NEWS I should mention this?

Looks very good to me.  See below for the nitpicks,

diff --git a/lisp/uniquify.el b/lisp/uniquify.el
index 70e8ecee74..8439d9d874 100644
--- a/lisp/uniquify.el
+++ b/lisp/uniquify.el
@@ -104,6 +104,13 @@ uniquify-buffer-name-style
   post-forward-angle-brackets   name<bar/mumble>   name<quux/mumble>
   nil                           name               name<2>

+The value can be set to a customized function with two mandatory
+arguments.  For example the current implementation for
+post-forward-angle-brackets could be:

You should describe those arguments rather than only tell the number of
args and show an example.  E.g.

   The value can be set to a customized function which will be called
   two arguments BASE and EXTRA-STRINGS where BASE is a string and
   EXTRA-STRINGS is a list of strings.  For example the current
   implementation for post-forward-angle-brackets could be:

+(defun my-post-forward-angle-brackets (base extra-string)
+  (concat base \"<\" (mapconcat 'identity extra-string \"/\") \">\"))

I'd use #' rather than ' to quote `identity`.


There is a new branch feature/uniquify-as-function.  I added some
documentation too. If it is fine confirm to merge into master.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]