[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Address issue with tab-bar

From: Juri Linkov
Subject: Re: [PATCH] Address issue with tab-bar
Date: Thu, 17 Sep 2020 22:07:02 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)

> I've noticed an issue where, if tab-bar-mode is t, but tab-bar-show is
> 1, then if you open a second tab, then close it, it will hide the tab
> bar and not show it again.
> e.g. running the following code will result in two tabs being open, but
> the tab bar not visible.
> (customize-set-variable 'tab-bar-show 1)
> (tab-bar-mode)
> (tab-bar-new-tab)
> (tab-bar-close-tab)
> (tab-bar-new-tab)
> The below patch addresses this issue by not hiding the tab bar if
> tab-bar-mode is t, in the same way that tab-bar-new-tab-to does.

But according to the documentation of 'tab-bar-show':

  "If the value is ‘1’, then hide the tab bar when it has only one tab,
  and show it again once more tabs are created."

tab-bar-close-tab should hide the tab-bar on the selected frame
with only one tab.

So the problem is that tab-bar-new-tab doesn't show the tab-bar again
when there are more than one tab.

It seems this is a consequence of bug#42052 that tried to implement
frame-local tab-bar where tab-bar-mode is always true, but it shows/hides
frame-local tab-bars depending on the frame-parameter 'tab-bar-lines'.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]