[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: feature/icomplete-vertical

From: Gregory Heytings
Subject: Re: feature/icomplete-vertical
Date: Sat, 19 Sep 2020 08:35:24 +0000
User-agent: Alpine 2.22 (NEB 394 2020-01-19)

There is another corner case that is when

(frame-parameter nil 'minibuffer) is 'only. This was also a problem reported some days ago needed when using frames and not the minibuffer.

Hmmm... in that case (a corner case, indeed, which does not seem to be covered by the current icomplete implementation), it means that the minibuffer is not resized att all? TBH, it seems to me that using icomplete with a minibuffer-only frame does not have much sense.

That being said, it is always possible to imagine more corner cases, for example a completion candidate that would fill more than one line, or a completion candidate list with different fonts (I'm not sure that this is actually feasible), or completion candidates with embedded newlines, or...

The other problem with the patch is that due to rounding and floor when using different fonts there is too much extra space missing and sometimes missed a candidate at the end. This was also reported some days ago.

I don't think so, but I could be wrong. I tested my code with many different parameters, and did not see the "extra space" you mention, in all cases the completions fit perfectly in the minibuffer, and the prompt is never hidden.

Look at the attached patch as it is partially simplified in my local branch.

Thanks, I'll have a look.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]