Re: master eaf224f: Repad the Face header in Gnus

[Lars Ingebrigtsen]

Alex Bochannek <alex@bochannek.com> writes:

> I went through a few years of Gnus newsgroups and other mailing lists to
> see if I can find Face headers that break. I found two people who posted
> invalid base 64 with embedded space characters. One case (a) was a
> simple issue of improper header folding. The other case (b) is an odd
> corner case where there is a single space right in a folded header field
> and the proper padding assigned as well. How about something like this
> to make case (a) display properly and not fail for case (b)?

[...]

> +(defcustom gnus-base64-repad-regexp "[A-Za-z0-9+/= ]"

I don't think this is necessary -- nobody would want to customise
something like this.

The philosophy in network communication is "be liberal in what you
receive", so when handling base64, all whitespace should simply be
discarded.  There is no downside to doing so, and trying to make base64
decoding be strict here is unnecessary.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no