Re: feature/icomplete-vertical

[João Távora]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: João Távora <joaotavora@gmail.com>
>> Date: Mon, 5 Oct 2020 00:47:39 +0100
>> Cc: Eli Zaretskii <eliz@gnu.org>, Gregory Heytings <ghe@sdf.org>, Yuan Fu 
>> <casouri@gmail.com>, 
>>      emacs-devel <emacs-devel@gnu.org>, Juri Linkov <juri@linkov.net>
>> 
>> (defun icomplete-vertical-adjust-minibuffer-height (completions)
>>   (let* ((comp completions)
>>           (complen (length (split-string comp "\n"))))
>>      (if (> complen 1) (enlarge-window (- icomplete-prospects-height (1- 
>> (window-height)))))
>>      comp))
>> (advice-add 'icomplete-completions :filter-return 
>> #'icomplete-vertical-adjust-minibuffer-height)
>
> What happens with your solution if you need to enlarge the mini-window
> to a height that is greater than the frame's height?

I don't know.  Wouldn't I need an extremely stubby frame to achieve
that?  Anyway, that's not even my code.  As I explained to Ergus, just
wanted to underline that a solution without new user interfaces can be a
starting point with bugs that are fixed as bugs.  I doubt that
systematically fixing these bugs would necessarily leads us to a
solution with N new defcustoms and a new minor mode.

João