emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: mouse-face and help echo support for xterm mouse


From: Stefan Monnier
Subject: Re: mouse-face and help echo support for xterm mouse
Date: Sun, 01 Nov 2020 08:39:49 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi Jared,

I really like this new feature but have just one comment/question?

> +  previous_help_echo_string = help_echo_string;
> +  help_echo_string = Qnil;
> +
> +  note_mouse_highlight(XFRAME(frame), XFIXNUM (mouse_x), XFIXNUM (mouse_y));
> +
> +  if (!NILP (help_echo_string)
> +      || !NILP (previous_help_echo_string))
> +    {
> +      gen_help_event (help_echo_string, frame, help_echo_window,
> +                      help_echo_object, help_echo_pos);
> +    }

I see this exact same code in other C files.
Could we move it to a file where we can share it instead of having
N copies?


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]