[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: on helm substantial differences
From: |
Stefan Monnier |
Subject: |
Re: on helm substantial differences |
Date: |
Mon, 16 Nov 2020 16:54:37 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
>> Before knowing what's the best approach, I think we should clearly
>> decide what would be the "ideal" new API. E.g. should it return "any
>> string" and then it'd be up to the infrastructure code to store
>> side-info about what is the corresponding candidate's actual text?
>> Or should it instead return a string with additional text-properties
>> explaining which parts are annotations and which part is the actual
>> candidate's text? Or should it return a list of strings? ...
> An additional question is at what stage to add faces like
> 'completions-common-part'? Currently annotations are appended
> after all commonality highlighting is done. But with returning
> a completion string, I guess such faces should be added
> on the returned string at the last stage.
The way faces like `completions-common-part` are applied is sometimes
problematic, indeed, but in this particular case I don't see what's
problematic about it: (as long as the matching is done on the
un-annotated candidates) I can't see why you're prefer to apply faces
like `completions-common-part` after adding annotations rather
than before.
Stefan
- RE: on helm substantial differences, Drew Adams, 2020/11/12
- Re: on helm substantial differences, Jean Louis, 2020/11/13
- Re: on helm substantial differences, Jean Louis, 2020/11/15
- Re: on helm substantial differences, Juri Linkov, 2020/11/15
- Re: on helm substantial differences, Stefan Monnier, 2020/11/15
- RE: on helm substantial differences, Drew Adams, 2020/11/15
- Re: on helm substantial differences, Juri Linkov, 2020/11/16
- RE: on helm substantial differences, Drew Adams, 2020/11/16
- Re: on helm substantial differences, Stefan Monnier, 2020/11/16
- Re: on helm substantial differences, Juri Linkov, 2020/11/16
- Re: on helm substantial differences,
Stefan Monnier <=
- Re: on helm substantial differences, Juri Linkov, 2020/11/17
- Re: on helm substantial differences, Juri Linkov, 2020/11/17
- Re: on helm substantial differences, Juri Linkov, 2020/11/18
- Re: on helm substantial differences, Basil L. Contovounesios, 2020/11/18
- Re: on helm substantial differences, Juri Linkov, 2020/11/18
- Re: on helm substantial differences, Juri Linkov, 2020/11/18
- Re: on helm substantial differences, Juri Linkov, 2020/11/20
- Re: on helm substantial differences, Eli Zaretskii, 2020/11/20
- Re: on helm substantial differences, Eli Zaretskii, 2020/11/20
- Re: on helm substantial differences, Stefan Monnier, 2020/11/20