emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 45a1653: ; Fix last change to bibtex.el


From: Basil L. Contovounesios
Subject: Re: master 45a1653: ; Fix last change to bibtex.el
Date: Wed, 18 Nov 2020 16:18:10 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> Glenn Morris <rgm@gnu.org> writes:
>
>>> commit 45a1653afa8eb0032908bc94b5466604f84805d5
>>
>>> diff --git a/lisp/textmodes/bibtex.el b/lisp/textmodes/bibtex.el
>>> index b69d715..d53cfa0 100644
>>> --- a/lisp/textmodes/bibtex.el
>>> +++ b/lisp/textmodes/bibtex.el
>>
>> [...]
>>
>>> -            (function :tag "Conversion function")))
>>> -(make-variable-buffer-local 'bibtex-unify-case-convert)
>>> +                 (function :tag "Conversion function"))
>>> +  :local t)
>>
>> After this change:
>>
>> bibtex-unify-case-convert:
>>   Its value is nil
>>   Original value was ‘identity’
>>
>> The "nil" value causes a test failure: 
>> https://hydra.nixos.org/build/130666989
>>
>> (Perhaps defcustom's recently added :local feature, of which this is the
>> only user, is broken.)
>
> Right.  I'll remove the :local for now, as per Roland's suggestion, and
> see if I can get the tag working as intended later.

How's the attached fix?

Eli, Lars: since :local is new in Emacs 27, can this patch be applied to
emacs-27?

Thanks,

-- 
Basil

Attachment: 0001-Fix-handling-of-defcustom-local-tag.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]