[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Additional cleanup around xterm-mouse
From: |
Stefan Monnier |
Subject: |
Re: Additional cleanup around xterm-mouse |
Date: |
Tue, 01 Dec 2020 10:21:40 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> I'm about 33% through analyzing read-key and have already found the
> following differences:
>
> * read-key resets this-command-keys, read-event appends to it.
I think this is a misfeature of `read-key`. I believe the better fix is
to introduce a new function which is like `read-key-sequence` but with
fewer side effects and on top of which we would re-implement `read-key`
and `read-key-sequence`.
By "fewer side effects", I mean that it should return a set of data:
- the key-sequence read.
- the corresponding list of undecoded input-events (instead of
modifying this-command-keys).
- the command that was found in the keymaps and which made the function
decide that this key sequence was complete (instead of setting
read_key_sequence_cmd).
- maybe more...
> * read-key does not return switch-frame events as they happen,
> read-event does.
I think this is what we want.
BTW, related to that, there is `read-char` which I believe can (almost?)
always be replaced with `read-key`.
Stefan
- Re: Additional cleanup around xterm-mouse, Jared Finder, 2020/12/01
- Re: Additional cleanup around xterm-mouse,
Stefan Monnier <=
- Re: Additional cleanup around xterm-mouse, Eli Zaretskii, 2020/12/01
- Re: Additional cleanup around xterm-mouse, Jared Finder, 2020/12/02
- Re: Additional cleanup around xterm-mouse, Stefan Monnier, 2020/12/02
- Re: Additional cleanup around xterm-mouse, Jared Finder, 2020/12/03
- Re: Additional cleanup around xterm-mouse, Stefan Monnier, 2020/12/03
- Re: Additional cleanup around xterm-mouse, Jared Finder, 2020/12/03
- Re: Additional cleanup around xterm-mouse, Jared Finder, 2020/12/13
- Re: Additional cleanup around xterm-mouse, Eli Zaretskii, 2020/12/14
- Re: Additional cleanup around xterm-mouse, Jared Finder, 2020/12/16
- Re: Additional cleanup around xterm-mouse, Eli Zaretskii, 2020/12/19