Re: [PATCH v2 00/16] Speeding up DEFVAR_PER_BUFFER

[Eli Zaretskii]

> Date: Mon, 30 Nov 2020 20:32:47 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: arnold@tdrhq.com, dgutov@yandex.ru, monnier@iro.umontreal.ca, rms@gnu.org,
>  emacs-devel@gnu.org
> 
> I started reviewing the patches again with this in mind, but ran out
> of time for today.  I will try very hard to respond by tomorrow

Now done.

To summarize:

  . I had some minor comments about the code and some questions
  . Can we please make the modified code faster by using macros
    instead of inline functions?
  . Please separate the series into a single patch that is needed to
    speed up let-binding of variables (skipping any intermediate
    steps), and several other patches for cleanups and simplifications
    not directly related to the speedup.
  . Please add log messages for each patch.

Last, but not least, I'd be happy if we could find a way of
benchmarking the change, to be sure we are not paying too heavy a
price for this.

Thanks!