Re: Redisplay slower in Emacs 28 than Emacs 27

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> So there's something off about how the image specs are being compared in
> the two cases.

With the following instrumentation:

diff --git a/src/image.c b/src/image.c
index 5eb4132295..f89649c61d 100644
--- a/src/image.c
+++ b/src/image.c
@@ -1597,8 +1597,12 @@ make_image_cache (void)
 static bool
 equal_lists (Lisp_Object a, Lisp_Object b)
 {
+  CALLN (Fmessage, build_string("%S %S"),
+        a, b);
   while (CONSP (a) && CONSP (b) && EQ (XCAR (a), XCAR (b)))
     a = XCDR (a), b = XCDR (b);
+  CALLN (Fmessage, build_string("%S %S"),
+        a, b);
 
   return EQ (a, b);
 }

I consistently get this from the toolbar icons:

(image :type xpm :file "/home/larsi/src/emacs/trunk/etc/images/search.xpm") 
(image :type xpm :file "/home/larsi/src/emacs/trunk/etc/images/search.xpm")
("/home/larsi/src/emacs/trunk/etc/images/search.xpm") 
("/home/larsi/src/emacs/trunk/etc/images/search.xpm")

That is, the two filenames are not EQ.  Is the toolbar code recreating
the filenames on every redisplay or something?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no