emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tab-line-alternate-colors


From: Adam Porter
Subject: Re: [PATCH] tab-line-alternate-colors
Date: Sun, 13 Dec 2020 05:13:45 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

> Yes, that seems like a good idea.  Something like this?  I also added
> another face for non-file-backed buffers, which helps distinguish
> them.

The attached patch fixes a bug with an anonymous face in the previous
patch.

By the way, it seems that, because the face `tab-line' inherits from the
face `variable-pitch', an anonymous face that inherits from
`tab-line-tab-special' (which defaults to italic slant in this patch) is
prevented from having italic slant applied.  If I set `tab-line' to not
inherit from `variable-pitch', the italic slant is inherited.
`variable-pitch' has not been customized, so it has no value for the
slant attribute, so it seems like it shouldn't interfere.  I don't know
if this is a bug in my code, in Emacs 28, or in the native-comp branch
that I'm using to develop this patch.

Thanks.

Attachment: 0001-New-tab-line-options-faces-and-face-function.patch
Description: patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]