[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master f45ce78 2/2: Explicitly specify svg base_uri using `:base-uri
From: |
Eli Zaretskii |
Subject: |
Re: master f45ce78 2/2: Explicitly specify svg base_uri using `:base-uri' image property |
Date: |
Sat, 26 Dec 2020 11:19:56 +0200 |
> From: Evgeny Zajcev <zevlg@yandex.ru>
> Date: Sat, 19 Dec 2020 15:24:38 +0300
> Cc: emacs-devel <emacs-devel@gnu.org>
>
> Do you think the current NEWS entry is sufficiently complete and
> accurate?
>
> Yeah, NEWS entries are good
>
> The patch LGTM, with a couple of wording nits:
>
> > * doc/lispref/display.texi: Add more documentation for `:base-uri'
>
> This should mention the name of the @node where the change is done, in
> parentheses (as if it were a function).
>
> > diff --git a/doc/lispref/display.texi b/doc/lispref/display.texi
> > index 2b3119ea59..2ecd14fed9 100644
> > --- a/doc/lispref/display.texi
> > +++ b/doc/lispref/display.texi
> > @@ -5904,7 +5904,13 @@ SVG Images
> > To @var{svg} add an embedded (raster) image placed at
> > @var{relative-filename}. @var{relative-filename} is searched inside
> > @code{file-name-directory} of the @code{:base-uri} svg image property.
> > -This improves the performance of embedding large images.
> > +@code{:base-uri} specifies a (possible non-existing) filename name of
> ^^^^^^^^ ^^^^^^^^^^^^^
> "possibly" and "file name".
>
> Noted, here is the updated patch
Thanks, pushed to the master branch.