[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New
From: |
Eli Zaretskii |
Subject: |
Re: master 7936c8a: * lisp/mb-depth.el (minibuffer-depth-indicator): New face. |
Date: |
Thu, 07 Jan 2021 21:26:40 +0200 |
> From: Juri Linkov <juri@linkov.net>
> Cc: Gabriel do Nascimento Ribeiro <gabriel376@hotmail.com>,
> emacs-devel@gnu.org
> Date: Thu, 07 Jan 2021 19:50:27 +0200
>
> > In toplevel form:
> > mb-depth.el:38:1: Warning: defface for `minibuffer-depth-indicator' fails
> > to
> > specify containing group
>
> The question is what group to add. Drew proposed :group 'convenience'
> and 'faces'. Gabriel proposed 'basic-faces'. But the problem is that
> minibuffer-depth-indicate-mode already has the :group 'minibuffer'.
> So it seems its face should be added to the same group.
Any reason NOT to add it to the 'minibuffer' group?