[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master a0f6029: Fix misuses of `byte-compile-macro-environment`
From: |
Basil L. Contovounesios |
Subject: |
Re: master a0f6029: Fix misuses of `byte-compile-macro-environment` |
Date: |
Wed, 03 Mar 2021 14:44:02 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
monnier@iro.umontreal.ca (Stefan Monnier) writes:
> branch: master
> commit a0f60293d97cda858c033db4ae074e5e5560aab2
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
> Fix misuses of `byte-compile-macro-environment`
This seems to result in the following test failure with 'make check',
but strangely not with 'make test/pcase-tests':
Test pcase-tests-macro backtrace:
signal(void-function (pcase-tests-plus--pcase-macroexpander))
apply(signal (void-function (pcase-tests-plus--pcase-macroexpander))
#f(compiled-function () #<bytecode -0x130ab4f40ca06d1f>)()
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name pcase-tests-macro :documentation nil
ert-run-or-rerun-test(#s(ert--stats :selector (not (or ... ...)) :te
ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/pcase-tes
command-line()
normal-top-level()
Test pcase-tests-macro condition:
(void-function pcase-tests-plus--pcase-macroexpander)
FAILED 5/9 pcase-tests-macro (0.000163 sec)
BTW, 'make bootstrap' now emits this warning:
In cl--sm-macroexpand:
emacs-lisp/cl-macs.el:2301:61: Warning: Unused lexical argument `dontcare'
(The 'sm' is the artist's signature, right? ;)
Is this the right fix?
>From a29983cbbfb1fbd7cb2773d1e2dc89483df82bf4 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Wed, 3 Mar 2021 12:49:31 +0000
Subject: [PATCH] ; Pacify unused var warning in cl--sm-macroexpand.
---
lisp/emacs-lisp/cl-macs.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el
index 91146c4d0e..c38dc44ff6 100644
--- a/lisp/emacs-lisp/cl-macs.el
+++ b/lisp/emacs-lisp/cl-macs.el
@@ -2298,7 +2298,7 @@ cl--sm-macroexpand
;; The behavior of CL made sense in a dynamically scoped
;; language, but nowadays, lexical scoping semantics is more often
;; expected.
- (`(,(or 'let 'let*) . ,(or `(,bindings . ,body) dontcare))
+ (`(,(or 'let 'let*) . ,(or `(,bindings . ,body) pcase--dontcare))
(let ((nbs ()) (found nil))
(dolist (binding bindings)
(let* ((var (if (symbolp binding) binding (car binding)))
--
2.30.1
Thanks,
--
Basil