[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Consistent face for keys in *Help* and `substitute-command-keys'
From: |
Juri Linkov |
Subject: |
Re: Consistent face for keys in *Help* and `substitute-command-keys' |
Date: |
Mon, 08 Mar 2021 11:17:55 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) |
> +(defface help-key-binding
> + '((((class color) (min-colors 88)) :foreground "ForestGreen")
> + (((class color) (min-colors 16)) :foreground "green")
> + (((class color) (min-colors 8)) :foreground "green")
> + (((class color grayscale) (background light)) :foreground "grey15")
> + (((class color grayscale) (background dark)) :foreground "grey85")
> + (t :foreground "ForestGreen"))
> + "Face for keybindings in *Help* buffers.
I wonder why green? It looks quite weird. All the most popular
markup renderers nowadays such as GitHub and GitLab display keybindings
using light grey background like this:
diff --git a/lisp/faces.el b/lisp/faces.el
index b2d47edca0..0f956b0cde 100644
--- a/lisp/faces.el
+++ b/lisp/faces.el
@@ -2816,11 +2816,11 @@ help-argument-name
:group 'help)
(defface help-key-binding
- '((((class color) (min-colors 88) (background light)) :foreground
"ForestGreen")
- (((class color) (min-colors 88) (background dark)) :foreground "#44bc44")
- (((class color grayscale) (background light)) :foreground "grey15")
- (((class color grayscale) (background dark)) :foreground "grey85")
- (t :foreground "ForestGreen"))
+ '((((class color) (min-colors 88) (background light)) :background "grey85")
+ (((class color) (min-colors 88) (background dark)) :background "grey25")
+ (((class color grayscale) (background light)) :background "grey85")
+ (((class color grayscale) (background dark)) :background "grey25")
+ (t :background "grey85"))
"Face for keybindings in *Help* buffers.
This face is added by `substitute-command-keys', which see.
BTW, I noticed after typing 'C-u C-x =' that face information is
duplicated:
There are text properties here:
face help-key-binding
font-lock-face help-key-binding
- Re: Consistent face for keys in *Help* and `substitute-command-keys', (continued)
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Eli Zaretskii, 2021/03/05
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Stefan Kangas, 2021/03/05
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Eli Zaretskii, 2021/03/06
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Stefan Kangas, 2021/03/06
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Stefan Kangas, 2021/03/06
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Eli Zaretskii, 2021/03/06
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Stefan Kangas, 2021/03/06
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Eli Zaretskii, 2021/03/07
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Stefan Kangas, 2021/03/07
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Eli Zaretskii, 2021/03/07
- Re: Consistent face for keys in *Help* and `substitute-command-keys',
Juri Linkov <=
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Stefan Kangas, 2021/03/08
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Juri Linkov, 2021/03/08
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Stefan Kangas, 2021/03/09
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Juri Linkov, 2021/03/10
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Stefan Kangas, 2021/03/10
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Juri Linkov, 2021/03/10
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Eli Zaretskii, 2021/03/10
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Stefan Kangas, 2021/03/10
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Stefan Monnier, 2021/03/10
- Re: Consistent face for keys in *Help* and `substitute-command-keys', Eli Zaretskii, 2021/03/11