Re: [ELPA] A Setup package

[Stefan Monnier]

> I think all the issues should now be resolved. I just pushed a commit
> adding edebug support.  setup-help was moved into setup's docstring, a
> lot of the macros were redefined to look more like setq, and all macros
> were redefined to use keywords (for now).

[ I have some further suggestions for the code, but they'll come later.  ]

I was about to add it to GNU ELPA, but I noticed two problems:

1- The file is missing a copyright notice and it is using the CC0 license.
   See the patch below to fix those issues (the copyright part reflects
   the fact that you consider the package as being covered by your
   copyright assignment and the license change is because we want to
   distribute all GNU ELPA packages under the GPLv3 license; you're of
   course perfectly free to also distribute this package under any other
   license you want, but we want to use the GPLv3 for the copy we
   distribute).

2- AFAIK you rebased (or force-pushed or something like that) your
   branch, which makes it painful for any"one" tracking your branch, such
   as elpa.git.  In order for the elpa.git branch tracking your
   SourceHut repository to work sanely it'll be important not to rebase
   (or force-push...) in the future.

Let me know when point 1 is fixed so I can add the package to GNU ELPA.


        Stefan


PS: I removed the "This file is NOT part of Emacs" line because this is
a bit problematic for GNU ELPA packages: they're at the same time part
of Emacs (the project) and not part of Emacs (the release tarballs) ;-)


diff --git a/setup.el b/setup.el
index e547243340..510c599d5f 100644
--- a/setup.el
+++ b/setup.el
@@ -1,18 +1,25 @@
 ;;; setup.el --- Helpful Configuration Macro    -*- lexical-binding: t -*-
 
+;; Copyright (C) 2021  Free Software Foundation, Inc.
+
 ;; Author: Philip K. <philipk@posteo.net>
 ;; Maintainer: Philip K. <philipk@posteo.net>
 ;; Version: 0.1.0
 ;; Package-Requires: ((emacs "26.1"))
 ;; Keywords: lisp, local
 
-;; This file is NOT part of Emacs.
-;;
-;; This file is in the public domain, to the extent possible under law,
-;; published under the CC0 1.0 Universal license.
-;;
-;; For a full copy of the CC0 license see
-;; https://creativecommons.org/publicdomain/zero/1.0/legalcode
+;; This package is Free Software: you can redistribute it and/or modify
+;; it under the terms of the GNU General Public License as published by
+;; the Free Software Foundation, either version 3 of the License, or
+;; (at your option) any later version.
+
+;; This package is distributed in the hope that it will be useful,
+;; but WITHOUT ANY WARRANTY; without even the implied warranty of
+;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;; GNU General Public License for more details.
+
+;; You should have received a copy of the GNU General Public License
+;; along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.
 
 ;;; Commentary: