Re: master b968323: Fix previous face.el change

[Stefan Kangas]

larsi@gnus.org (Lars Ingebrigtsen) writes:

> branch: master
> commit b9683230ecaada87f23bdba59ef044c4b0374216
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Fix previous face.el change
>
>     * lisp/faces.el (require): Fix compilation warning from previous
>     face.el change.
> ---
>  lisp/faces.el | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/lisp/faces.el b/lisp/faces.el
> index 3ea4c94..1067556 100644
> --- a/lisp/faces.el
> +++ b/lisp/faces.el
> @@ -25,6 +25,8 @@
>
>  ;;; Code:
>
> +(eval-when-compile (require 'subr-x))
> +

This commit breaks bootstrap here:

    Loading /home/skangas/wip/emacs/lisp/faces.el (source)...
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    Loading /home/skangas/wip/emacs/lisp/cus-face.el (source)...
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    Loading /home/skangas/wip/emacs/lisp/faces.el (source)...
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    [... snip ...]
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    make[3]: *** [Makefile:279: emacs-lisp/autoload.elc] Segmentation fault

I find `string-trim' an obviously useful addition to Emacs Lisp, so I
suggest moving it to subr.el instead.

That might call for adding it to the ELisp Manual as well.