Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063)

[Lars Ingebrigtsen]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> Lars, any thoughts on how best to protect M-x from errors in
> completion-predicate?  Is the following okay?

[...]

> +      (condition-case-unless-debug err
> +          (funcall (get symbol 'completion-predicate) symbol buffer)
> +        (error
> +         (message "command-completion-default-include-p: %s: %S" symbol err)
> +         nil))

What's the performance impact here?  This is going to be called a whole
bunch of times when the user hits TAB...

I'm also not quite sure why we should be ignoring these errors --
they're code errors, like any others, and shouldn't be expected to
fail, should they?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no