[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Lazy wdired preprocessing
From: |
Arthur Miller |
Subject: |
Re: [PATCH] Lazy wdired preprocessing |
Date: |
Fri, 26 Mar 2021 13:21:53 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Michael Heerdegen <michael_heerdegen@web.de> writes:
> Arthur Miller <arthur.miller@live.com> writes:
>
>> This was re-implementation of parts of wdired to make it more efficient
>> and faster to enter the wdired mode.
>
> Ok, thanks for the elaboration. Didn't try it yet, but I welcome this
> change. So far I have one question:
>
> + ;; find one column with permissions and set permision text boundaries
> + (save-excursion
> + (goto-char (point-min))
> + (unless (re-search-forward dired-re-perms nil t 1)
> + (wdired-abort-changes)
> + (error "No files to be renamed - Exiting to Dired mode."))
> + (goto-char (match-beginning 0))
> + (setq-local wdired-perm-beg (current-column))
> + (goto-char (match-end 0))
> + (setq-local wdired-perm-end (current-column)))
>
> Did you check that this works when `dired-hide-details-mode' is enabled?
> I ask because AFAIK `current-column' doesn't count invisible characters.
> [It might be better to just count characters from the line's beginning,
> but I see that the existing code also uses `current-column'.]
I just tested bit more. Once wdired is entered with hidden details, one
can not switch deatils on normally since dired-hide-details-mode checks
if it is in dired-mode.
- [PATCH] Lazy wdired preprocessing, Arthur Miller, 2021/03/25
- Re: [PATCH] Lazy wdired preprocessing, Michael Heerdegen, 2021/03/25
- Re: [PATCH] Lazy wdired preprocessing, Arthur Miller, 2021/03/25
- Re: [PATCH] Lazy wdired preprocessing, Michael Heerdegen, 2021/03/25
- Re: [PATCH] Lazy wdired preprocessing, Arthur Miller, 2021/03/26
- Re: [PATCH] Lazy wdired preprocessing,
Arthur Miller <=
- Re: [PATCH] Lazy wdired preprocessing, Michael Heerdegen, 2021/03/27
- Re: [PATCH] Lazy wdired preprocessing, Stefan Monnier, 2021/03/27
- Re: [PATCH] Lazy wdired preprocessing, Michael Heerdegen, 2021/03/27
- Re: [PATCH] Lazy wdired preprocessing, Stefan Monnier, 2021/03/27
- Sv: [PATCH] Lazy wdired preprocessing, arthur miller, 2021/03/28
- Re: Sv: [PATCH] Lazy wdired preprocessing, Stefan Monnier, 2021/03/28
- Sv: Sv: [PATCH] Lazy wdired preprocessing, arthur miller, 2021/03/28
- Message not available
- Sv: Sv: [PATCH] Lazy wdired preprocessing, arthur miller, 2021/03/29
Re: [PATCH] Lazy wdired preprocessing, Stefan Kangas, 2021/03/26
Re: [PATCH] Lazy wdired preprocessing, Stefan Monnier, 2021/03/26