[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] icomplete-vertical

From: Eli Zaretskii
Subject: Re: [PATCH] icomplete-vertical
Date: Tue, 06 Apr 2021 05:31:15 +0300

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Mon, 5 Apr 2021 18:08:02 -0700
> Cc: emacs-devel@gnu.org
> Gregory Heytings <gregory@heytings.org> writes:
> >> Why is this a patch that uses advice and hook instead of a user option
> >> that changes the behaviour of icomplete directly?
> >
> > Because it's the simplest / cleanest way to do it.  It's a kind of derived
> > minor mode.
> Advice is not entirely unproblematic though, so the recommendation is
> usually to avoid them in libraries for use by others.  Even more so in
> Emacs itself, I think.
> See the ELisp Manual sections `(elisp) Advising Named Functions' and
> `(elisp) Coding Conventions'.

Indeed, we prefer not to use advice in our own code.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]