[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Simple isearch concerns

From: Gregory Heytings
Subject: Re: Simple isearch concerns
Date: Tue, 06 Apr 2021 20:10:13 +0000

Thanks for reviewing, again!

+(put 'beginning-of-buffer 'isearch-match-scroll t)
+(put 'end-of-buffer 'isearch-match-scroll t)
+(put 'scroll-up-command 'isearch-match-scroll t)
+(put 'scroll-down-command 'isearch-match-scroll t)
+(put 'beginning-of-buffer 'isearch-match-scroll-command 
+(put 'end-of-buffer 'isearch-match-scroll-command 'isearch-end-of-buffer)
+(put 'scroll-up-command 'isearch-match-scroll-command 'isearch-scroll-up)
+(put 'scroll-down-command 'isearch-match-scroll-command 'isearch-scroll-down)

Why such unnecessary duplication? When 'beginning-of-buffer' has the property 'isearch-match-scroll-command' this means it has a non-nil value. There is no need to duplicate this fact with isearch-match-scroll=t.

Indeed, see the attached simplified patch.

+  :type '(choice (const :tag "Off" nil)
+                 (const tag "On" t))


Attachment: 0001-New-user-option-to-scroll-isearch-matches.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]