[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] icomplete-vertical

From: Juri Linkov
Subject: Re: [PATCH] icomplete-vertical
Date: Sun, 11 Apr 2021 01:39:39 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)

>> Good to see that the new branch avoids such hacks.  I tested it out,
>> and everything is nice.
> Did you test the branch that me and Gregory are working
> on off-list?
> Probably we should be on-list.  The branch is
> scratch/icomplete-vertical-mode-gregory-and-joao and it's
> functionally equivalent to Gregory's last on-list patch but a bit
> simpler and cleaner on the implementation.

Ergus discovered this new branch, so I tried it out.

> C-n and C-p are supported, but indeed C-v and M-v are not.
> It's a good idea to support them, yes. And maybe your idea is
> the best way.  Feel free to add a commit or two to that branch.
> Else, let's just push this simpler version to master.

If the basic functionally already works, then better to push the
existing version to master.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]