emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] `completing-read`: Add `group-function` support to completio


From: Daniel Mendler
Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 2)
Date: Fri, 30 Apr 2021 20:30:48 +0200

On 4/30/21 8:11 PM, Daniel Mendler wrote:
> On 4/30/21 7:01 PM, Juri Linkov wrote:
>> Thanks, I tested the vertical and horizontal format,
>> and the horizontal format is displayed nicely, but I expected
>> that in the vertical format completions inside every group
>> to be arranged the same way as in horizontal format, e.g.
>> everything is fine in the horizontal format:
> 
> Yes, this is intentional. I assume that one would want to have headers
> per column as in a two column paper layout for example. We can also use
> the different layout if that is preferred.

I believe the arrangement I am using in the current patch is is the more
natural one.

For the horizontal layout we insert the candidates like this:

>>-----------\
             |
/------------/
|
\------------\
             |
/------------/
|
\----------->>

For the vertical layout we insert the candidates like this:

v  /--\  /--\
v  |  |  |  |
|  |  |  |  |
|  |  |  |  |
|  |  |  |  v
\--/  \--/  v

What you proposed for the vertical layout would look like this

v  /--\  /--\
v  |  |  |  |
|  |  |  |  v
\--/  \--/  v
=============
v  /--\  /--\
v  |  |  |  |
|  |  |  |  v
\--/  \--/  v
=============
v  /--\  /--\
v  |  |  |  |
|  |  |  |  v
\--/  \--/  v

This seems to me like a mix of vertical and horizontal layout.

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]