[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] When deleting in bookmark menu, prompt for confirmation.

From: Stefan Kangas
Subject: Re: [PATCH] When deleting in bookmark menu, prompt for confirmation.
Date: Mon, 3 May 2021 07:48:00 -0500

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Karl Fogel <kfogel@red-bean.com> writes:
>> I wanted to run this by folks here to get opinions/review before
>> committing.  It stems from a suggestion by Oliver Taylor in a thread
>> on the Emacs Humanites mailing list (the thread is linked to from the
>> commit message).
> [...]
>>   (bookmark-menu-confirm-deletion): New defcustom.
> In general, I think it's better to offer undo instead of prompting.
> That's not always possible, but I think in the bookmark case, that
> shouldn't be too difficult -- just register an undo action that inserts
> the items that were removed, I think?

I think a confirmation here is in order, as this is a dangerous
operation.  For the same reason, we should ask the user to disable the
prompt rather than the other way around, i.e. the default should be t.

Undoing is also fine, but it is less discoverable, as you would need to
know that an action can be undone to use it.  OTOH, we could call it out
in the major mode help.

Perhaps if we had undo, it would make more sense to have the
confirmation nil by default.  (But I do wonder if many users would
then bother setting that option to t.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]