Re: [PATCH] Fix rendering issues on window managers without _NET_WM_STATE

[martin rudalics]

>      This patch fixes a bug that occurs when running Emacs in a window
> manager that does not set _NET_WM_STATE. The patch is simplest fix
> that restores expected behavior for window managers that do not set
> _NET_WM_STATE, but I have no idea whether there are other issues that
> may be occurring.
>
> I'm guessing that there are also likely issues with other logic in the
> MapNotify case that uses not_hidden for window managers that does not
> set _NET_WM_STATE.
>
> Thus, the more complex solution, which I am not knowledgeable enough
> to implement correctly, is to fix x_get_current_wm_state so that it
> works on window managers that do not set _NET_WM_STATE.
>
> I am unfamiliar with this section of the code, so my explanation may
> be off and a sanity check would be appreciated. Best,

Thanks.  This explains why our MapNotify code was not able to handle
visibility correctly with some WMs.  Actually, this also means that we
should get rid of x_get_current_wm_state because it apparently fails in
too many cases.

Unfortunately, reverting parts of 483c5e953c1 as in your patch will only
reintroduce the bug 483c5e953c1 was trying to fix.  I meanwhile checked
in a different solution based on handling VisibilityNotify.  Please try
with latest master and tell us whether the problem still exists.

Thank you, martin