emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default


From: Basil L. Contovounesios
Subject: Re: [PATCH] lisp/bookmark.el: make bookmark-fontify nil by default
Date: Tue, 18 May 2021 11:49:34 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

"Paul W. Rankin" via "Emacs development discussions."
<emacs-devel@gnu.org> writes:

> On 2021-05-18 16:58, Karl Fogel wrote:
>> On 18 May 2021, Paul W. Rankin" via "Emacs development discussions. wrote:
>>> Ugh. Not sure how this slipped into master but it is not a
>>> good/considerate idea to set default value of bookmark-fontify to t.
>>> If there are no reasonable objections I'll push this later today.
>> I don't have a strong opinion either way, but if you're curious as to
>> where this came from, it was here:
>> The discussion in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48179
>> is quite long, so it might be worth reading before reverting.
>
> Hi Karl,
>
> The discussion there only seems to account for compatibility with package 
> bm.el,
> not the more general "avoid pushing your idea onto everyone" idea. And given 
> the

The discussion there also raises concerns about some unintended
consequences of the new feature, such as with Org refile/capture[1] or
when overwriting an existing bookmark[2].

[1] https://bugs.gnu.org/48179#63
[2] https://bugs.gnu.org/48179#60

So I suggest you chime in there.

> overlay is temporary, it's quite opaque for the average person to inspect it 
> to
> see what's actually happening. It's so ugly my first thought was that 
> something
> had broken rather than this was actually an intentional feature.
>
> I'm going to commit this without further discussion -- which hopefully should
> remind others to take the more considerate route when introducing new 
> features!

-- 
Basil



reply via email to

[Prev in Thread] Current Thread [Next in Thread]