emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and,


From: Daniel Semyonov
Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations
Date: Wed, 26 May 2021 22:32:38 +0300

>>>>> João Távora writes:

    > Found it, it was in
    > https://github.com/joaotavora/eglot/issues/577, and the author,
    > Daniel Semyonov, is using `completing-read` directly. IOW it's not
    > specific to icomplete at all.  Here is his code.

    > In that issue he states that Eglot's completion table is
    > problematic, and he's probably right, but the general idea of
    > making a completion-in-region-function from completing-read is
    > very interesting.  It would in principle mean that every
    > completing-read frontend could also be used in many other places.

Not to derail the thread, but I do not recommend attempting to use that
function; I wrote it when I had a far worse understanding of the
completion system (and by pulling bits from various other functions I've
found online and in Emacs).  A far more robust implementation of the
same idea can be found in Daniel Mendler's Consult package (although
last I tested it also had issues with Eglot).

Regards,

  Daniel







reply via email to

[Prev in Thread] Current Thread [Next in Thread]