[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: src/nsterm.m: fix window tabbing on macOS

From: Alan Third
Subject: Re: src/nsterm.m: fix window tabbing on macOS
Date: Sun, 6 Jun 2021 19:56:58 +0100

On Sun, Jun 06, 2021 at 10:19:57PM +1000, Paul W. Rankin wrote:
> > On 6 Jun 2021, at 9:36 pm, Alan Third <alan@idiocy.org> wrote:
> > 
> > On Sun, Jun 06, 2021 at 07:07:53PM +0900, Naofumi Yasufuku wrote:
> >> 
> >> I found the following issues with this macOS native tab commit.
> >> Does anyone else encounter the same problems?
> >> 
> >> 1) Frame height increases (even if frame-inhibit-implied-resize is t).
> >>  attachment:
> >>    01_macOS-tab-issue-increases-height.gif
> >>    01_macOS-tab-issue-increases-height-2.gif … (sets 
> >> frame-inhibit-implied-resize t)
> > 
> > Strangely I don't see this. The frame stays the same height...
> Alan did you see my video of this in action?
> https://f002.backblazeb2.com/file/pwr-share/emacs_nsterm.mov

Yeah, I was wrong, it is there and it's very annoying. I think there's
a mismatch between the calculation of the height of the content and
the actual height of the content. But if it's that I have no idea why
it disappears when the toolbar is turned off, because the calculation
should still be wrong.

> >> 2) New tab name is ‘emacs’ instead of buffer name.
> >>    (even if C-x 5 C-f `find-file-other-frame’)
> >>  attachment:
> >>    02_macOS-tab-issue-odd-tab-name.gif
> > 
> > It turns out that when multiple NSViews are put into one NSWindow
> > using tabs, AppKit doesn't bother telling all the views to update
> > themselves when the window changes, it appears to only message the
> > currently visible one. This is a problem.
> > 
> > The tab name issue can be sorted with this change:
> > ...
> Interestingly this only happens with tool-bar-mode on. With eamcs -Q
> (tool-bar-mode 0) new frames/tabs get the correct name. Which makes
> me wonder if it's another case of some code somewhere interfering?

They don't here. The non-selected frame ends up with the wrong name
whether the toolbar is on or off.

> >> 3) Tabs are not shown in fullscreen.
> >>  attachment:
> >>    03_macOS-tab-fullscreen-expected-textedit.gif. .. e.g. macOS Test Edit 
> >> app
> >>    03_macOS-tab-issue-fullscreen-emacs.gif
> Yeah we're considering this a separate nice-to-have, right?

Yeah, the tabs work exactly as I'd expect them to in fullscreen given
the way fullscreen works just now.

I have to say I've spent most of the afternoon on this and I'm no
closer to a solution to the height changing thing, so I'm tempted to
revert the commit, or put it behind a build flag or something until we
have a better solution.
Alan Third

reply via email to

[Prev in Thread] Current Thread [Next in Thread]