[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pcase.el: Add cl-type and type patterns

From: Adam Porter
Subject: Re: [PATCH] pcase.el: Add cl-type and type patterns
Date: Fri, 16 Jul 2021 04:32:04 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hi Eli,

Eli Zaretskii <eliz@gnu.org> writes:

> A couple of comments about the documentation parts below.  I'll leave
> the main part to other reviewers.

>> +@item (cl-type @var{type})
>> +Matches if @var{expval} is of type @var{type}, which is a symbol or
>> +list as accepted by @ref{cl-typep,,,cl,Common Lisp Extensions}.
> Please don't use @ref with this "HTML-style", it produces bad results
> in Info.  Instead, use a slightly more wordy
>   ... as accepted by @code{cl-typep} (@pxref{cl-typep,,,cl,Common Lisp
>   Extensions}).

Sure, I've changed it.

>> +Example: @code{(cl-type integer)}
>> +Example: @code{(cl-type (integer 0 10))}
> Examples should be in a @lisp..@end lisp block, and then you can drop
> the @code markup, which is applied automatically.

Ok, I've changed that two-line example to use "@lisp...@end lisp".  I've
left the one-line example in the second patch in the "Example:
@code{...}" format, which matches all of the other single-line examples
in control.texi.  If you want me to change that one as well, let me

>> +*** Added Pcase 'cl-type' pattern.
>              ^^^^^
> "pcase", without capitalization.

The "Pcase" there was actually redundant, being present in the parent
heading, so I've removed it.

Please see the attached, updated patches.  Thanks for your help.

Attachment: 0001-lisp-emacs-lisp-cl-macs.el-Add-cl-type-pattern.patch
Description: Add cl-typep pattern

Attachment: 0002-lisp-emacs-lisp-pcase.el-Add-type-pattern.patch
Description: Add type pattern

reply via email to

[Prev in Thread] Current Thread [Next in Thread]