[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 9ac6ff5: Make the test for auto-mode-alist from .dir-local.el
Re: master 9ac6ff5: Make the test for auto-mode-alist from .dir-local.el stricter
Sat, 24 Jul 2021 10:28:19 -0400
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
Lars Ingebrigtsen [2021-07-24 11:30:20] wrote:
> firstname.lastname@example.org (Lars Ingebrigtsen) writes:
>> + (not (provided-mode-derived-p mode 'special-mode))))
> This may be too strict... on the other hand, perhaps the check should
> be even stricter -- perhaps a whitelist of allowed modes? (Perhaps (by
> default) populated from `auto-mode-alist'.)
Could you clarify what is the purpose of this test?
AFAICT the test that "corresponds" to what we do for file-local
variables is just to check the `-mode` suffix (since we accept any
`mode:foo` and call `foo-mode`).
So if you think we should make it stricter for the dir-local
auto-mode-alist, maybe we should also make it stricter for the
file-local `mode:` thingy.